Skip to content

docs: guide Flashduty large-list scans#80

Closed
ysyneu wants to merge 1 commit into
feat/ai-srefrom
audit-fix/20260709-flashduty-skill-guidance
Closed

docs: guide Flashduty large-list scans#80
ysyneu wants to merge 1 commit into
feat/ai-srefrom
audit-fix/20260709-flashduty-skill-guidance

Conversation

@ysyneu

@ysyneu ysyneu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add Flashduty skill guidance to redirect page-sized JSON/list scans to temp files and summarize selected fields only.
  • Add incident-summary reuse guidance to avoid redundant incident subquery fetches.
  • Add a skilldoc test that guards the guidance in the CLI-owned Flashduty skill source.

Audit Context

Automation: fc-safari-audit-session
Run: audit-20260709T031722Z-auto
Window: 2026-07-08T03:15:34.438Z -> 2026-07-09T03:17:22.000Z

Safari embeds this skill, but the command-card source of truth lives here, so this companion PR keeps the source guidance explicit.

Verification

  • go test ./internal/skilldoc
  • make check-cards
  • go test -race ./...
  • go build -v -ldflags "-s -w ..." -o bin/flashduty ./cmd/flashduty
  • committed branch review: no blocking findings
  • ./bin/golangci-lint run remains blocked in this local environment because the available golangci-lint reports it was built with Go 1.24 while the repo targets Go 1.25.1; rebuilding via go install in this shell produced the same embedded Go version.

@ysyneu ysyneu left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review blocker(P1):insight incident-list 单页最多 100 条并返回 search_after_ctx/total,但新指南要求 one JSON capture 后直接做账号级多维聚合。命中 >100 时会静默只统计第一页。请改为优先服务端聚合;必须扫原始列表时,先按 cursor 拉齐并核对累计条数与 total,再对完整文件聚合。验证中 race tests、skilldoc check、build 与 CI 均通过,但它们未覆盖该语义错误。

@ysyneu

ysyneu commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

关闭:当前方案会把 insight incident-list 的单页结果当成全量数据,账号命中超过 100 条时静默漏算。错误指导不应发布;未来如重做,必须使用服务端聚合,或按 cursor 拉齐全部页面并核对 total

@ysyneu ysyneu closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant